Don't override intentionally set project names. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's status on this? In case this needs more time, can we at least remove it from readme? It took me a while the mistake wasn't on my side :( |
|
👍 |
|
This should really be merged @dselans but you guys will need to validate that it doesn't change project names anywhere. Validating that is a matter of checking the filename vs the service name. |
|
@actaeon help getting this tested so a merge doesn't break a lot of projects would be appreciated. |
|
@relistan offsite this week :) , will look at it Monday. |
|
@intjonathan @actaeon @spkane want to merge or close this. Can you guys check it out, or help get someone else to? |
|
I'm going to do a 1.8.9 with the timeout fixes first, then come back to this as a 1.8.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is grabbed from #128 thanks to @MarkBorcherding. It will change the behavior of Centurion to fix a bug, but may have the unintended consequence of changing the names of services that are currently running and have been getting the name of the file rather than the
:namethey tried to set. I know that this might break some deployments at New Relic and will need to be investigated before this can be merged. The effect would be duplicate services running in the worst case, one new version, one old. For services that bind to ports the risk of this is lower since they will collide. But it would need manual intervention to fix. We need to investigate all the service configs to see if this is an issue.cc @benders @dselans